fix: correct swapped min/max metric names in vdom-resource - #385
Merged
bastischubert merged 2 commits intoMar 26, 2026
Merged
Conversation
The min_guaranteed_value map key was mapped to the _max_value metric name and vice versa. Any dashboard using these metrics silently showed inverted values. Signed-off-by: Aprazors <Aprazors@gmail.com>
Aprazor
force-pushed
the
fix/vdom-resource-swapped-metric-names
branch
from
March 21, 2026 04:54
094bc66 to
9514ff1
Compare
Contributor
|
Seems right, my bad. Update the test case with new values as well |
Per reviewer feedback, update the test expected output to match the corrected metric name mapping. Signed-off-by: Aprazors <Aprazors@gmail.com>
Philldomd
approved these changes
Mar 23, 2026
Philldomd
left a comment
Philldomd
left a comment
Contributor
There was a problem hiding this comment.
Great find thx for the contribution :)
Contributor
Author
|
done, test expectations updated in the second commit. thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The min_guaranteed_value map key was mapped to the _max_value metric
name and vice versa. Any dashboard using these metrics silently
showed inverted values.